[WIP] Implement terraform bootstrap stage #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelovilla
suggested changes
Sep 23, 2024
web/deploy/terraform/modules/bootstrap/state_storage/dynamodb-policy.json.tpl
Outdated
Show resolved
Hide resolved
web/deploy/terraform/modules/bootstrap/state_storage/variables.tf
Outdated
Show resolved
Hide resolved
web/deploy/terraform/staging/main.tf
Outdated
Comment on lines
15
to
27
| module "shared_resources" { | ||
| source = "../modules/shared_resources" | ||
| source = "../modules/shared_resources" |
There was a problem hiding this comment.
We won't be calling this module from each environment because otherwise we'll end up with duplicate resources. You'll want to extract this call to its own file that we run only once
smokestacklightnin
force-pushed
the
infra/bootstrap-state-storage
branch
from
1ecf003 to
8a8db15
Compare
Remove `README.md` because it outlines a manual process that is not automated by terraform/opentofu
smokestacklightnin
force-pushed
the
infra/bootstrap-state-storage
branch
from
8a8db15 to
70021ad
Compare
smokestacklightnin
force-pushed
the
infra/bootstrap-state-storage
branch
from
70021ad to
6ed16ca
Compare
smokestacklightnin
force-pushed
the
infra/bootstrap-state-storage
branch
from
b4678c1 to
31dd6a0
Compare
smokestacklightnin
changed the title
smokestacklightnin
force-pushed
the
infra/bootstrap-state-storage
branch
from
73f5155 to
bf7263f
Compare
There was a problem hiding this comment.
@smokestacklightnin we still need to define the S3 backend created on the state stage inside the shared and staging folders. You can adapt the existing terraform backend block or move it to its own backend.tf file
web/deploy/terraform/state/main.tf
Outdated
| } | ||
|
|
||
| module "stage_state" { | ||
| source = "./modules/" |
There was a problem hiding this comment.
You'd usually specify the module name, but it would need to be inside a subfolder. Do you think it would make sense to move those files to their own subfolder and then specify its name here?
|
superceded by #67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a work in progress.
This PR implements a bootstrap stage to create state resources discussed in Issue #60.
This PR includes:
Important: The IAM policy logic will need to be uncommented before this PR is merged.